[PATCH] D98603: [Flang] [OpenMP] Add function for mapping OpenMP Parser clause classes with the corresponding clause kind

[Praveen G via Phabricator via llvm-commits]

praveen marked 4 inline comments as done.
praveen added a comment.

@kiranchandramohan @clementval Thanks for the review . I have updated the test case for the Tablegen changes.

The clang-tidy seems to identify the case style as invalid for this function name **GenerateFlangClauseParserKindMap** 
Any changes required regarding this ? All other functions in the file DirectiveEmitter.cpp follows the same naming convention.



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:1460
+  // Clauses with OmpObjectList as its data member
+  using MemberObjectListClauses = std::tuple<parser::OmpClause::Copyprivate,
+      parser::OmpClause::Copyin, parser::OmpClause::Firstprivate,
----------------
clementval wrote:
> We could maybe generate this list from TableGen as well since we have the information. Anyway doesn't need to be done in this patch. 
I have added this in TODO . Thanks


================
Comment at: llvm/utils/TableGen/DirectiveEmitter.cpp:652
+// corresponding clause Kind
+void GenerateFlangClauseParserKindMap(const DirectiveLanguage &DirLang,
+                                      raw_ostream &OS) {
----------------
clementval wrote:
> kiranchandramohan wrote:
> > Would it be possible to add a test in the following file?
> > test/TableGen/directive1.td
> Right. I missed that point. +1
Updated the test file test/TableGen/directive1.td . Thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98603/new/

https://reviews.llvm.org/D98603