[PATCH] D90831: DebugInfo support for OCaml bindings

Vaivaswatha Nagaraj via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 16 10:46:28 PDT 2021


vaivaswatha updated this revision to Diff 331042.
vaivaswatha marked 6 inline comments as done.
vaivaswatha added a comment.

I've updated the patch addressing some of your comments. In particular, I didn't add a reference to the C-API to the functions where I had already provided the explanations inline (and the C-API comment doesn't add more value).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90831/new/

https://reviews.llvm.org/D90831

Files:
  llvm/bindings/ocaml/.ocamlformat
  llvm/bindings/ocaml/CMakeLists.txt
  llvm/bindings/ocaml/README.txt
  llvm/bindings/ocaml/debuginfo/CMakeLists.txt
  llvm/bindings/ocaml/debuginfo/debuginfo_ocaml.c
  llvm/bindings/ocaml/debuginfo/llvm_debuginfo.ml
  llvm/bindings/ocaml/debuginfo/llvm_debuginfo.mli
  llvm/bindings/ocaml/llvm/CMakeLists.txt
  llvm/bindings/ocaml/llvm/META.llvm.in
  llvm/bindings/ocaml/llvm/llvm.ml
  llvm/bindings/ocaml/llvm/llvm.mli
  llvm/bindings/ocaml/llvm/llvm_ocaml.c
  llvm/bindings/ocaml/llvm/llvm_ocaml.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90831.331042.patch
Type: text/x-patch
Size: 83323 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210316/a12fba9f/attachment.bin>


More information about the llvm-commits mailing list