[llvm] fe990ee - [Docs] Mention linking to reviews page when committing
Vaivaswatha Nagaraj via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 16 10:35:19 PDT 2021
Author: Vaivaswatha Nagaraj
Date: 2021-03-16T23:04:22+05:30
New Revision: fe990ee8159616d0739b315d0a961adb9c5695eb
URL: https://github.com/llvm/llvm-project/commit/fe990ee8159616d0739b315d0a961adb9c5695eb
DIFF: https://github.com/llvm/llvm-project/commit/fe990ee8159616d0739b315d0a961adb9c5695eb.diff
LOG: [Docs] Mention linking to reviews page when committing
Differential Revision: https://reviews.llvm.org/D98695
Added:
Modified:
llvm/docs/DeveloperPolicy.rst
Removed:
################################################################################
diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index 6b6fe29a963e..361aedb8e6c5 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -291,6 +291,9 @@ Below are some guidelines about the format of the message itself:
related commit. This could be as simple as "Revert commit NNNN because it
caused PR#".
+* If the patch has been reviewed, add a link to its review page, as shown
+ `here <https://www.llvm.org/docs/Phabricator.html#committing-a-change>`_.
+
For minor violations of these recommendations, the community normally favors
reminding the contributor of this policy over reverting. Minor corrections and
omissions can be handled by sending a reply to the commits mailing list.
More information about the llvm-commits
mailing list