[PATCH] D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D95916#2628775 <https://reviews.llvm.org/D95916#2628775>, @luismarques wrote:

> In D95916#2627640 <https://reviews.llvm.org/D95916#2627640>, @MaskRay wrote:
>
>> With -g or -fasynchronous-unwind-tables, .debug_frame/.eh_frame has a label below `_start`. Its address is `_start + 2` and its name is empty.
>> Neither addr2line nor llvm-symbolizer skips such a symbol with empty name.
>
> But D98669 <https://reviews.llvm.org/D98669> doesn't fix my original test case...?

Could you recheck? (I am quite certain it fixes your case)

addr2line PR: https://sourceware.org/bugzilla/show_bug.cgi?id=27585

Without that patch (my fllvm-symbolizer is an alias)

  % fllvm-symbolizer -fe a.out $(nm a.out | awk '/ _start/{printf "%#x",strtonum("0x"$1)+4}')                                 
  
  a.c:0:0

With that patch

  % fllvm-symbolizer -fe a.out $(nm a.out | awk '/ _start/{printf "%#x",strtonum("0x"$1)+4}')
  _start
  ??:0:0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95916/new/

https://reviews.llvm.org/D95916