[PATCH] D95339: [RFC][test] Adapt debug-info lit framework for more general purposes - part 1

Tue Mar 16 02:06:10 PDT 2021

jhenderson added a comment.

In D95339#2626418 <https://reviews.llvm.org/D95339#2626418>, @mehdi_amini wrote:

> How does LLVM_ENABLE_PROJECTS=cross-project-tests will work if only configure a subset of the projects? Or will it requires all the projects to be configured?

By the end of the patch series, the aim is to have tests marked as UNSUPPORTED if certain tools cannot be found, possibly due to them not being in LLVM_ENABLE_PROJECTS. If they are in LLVM_ENABLE_PROJECTS and cannot be found, the tests will fail.

The existing rules already mark some tests as UNSUPPORTED if lldb is not found in the environment somewhere (possibly because it is built due to being in LLVM_ENABLE_PROJECTS, or possibly because it is installed on the machine).

D96511 <https://reviews.llvm.org/D96511> (the fourth patch in this series) will mark tests as UNSUPPORTED if clang can't be found and isn't in LLVM_ENABLED_PROJECTS. The configuration matrix in this case would be:

- clang in "LLVM_ENABLED_PROJECTS" and clang not found - error for missing tool.
- clang in "LLVM_ENABLED_PROJECTS" and clang found using existing rules (either in build output or via environment variables) - tests run.
- clang not in "LLVM_ENABLED_PROJECTS" and clang not found - debuginfo_tests (and any other tests added in the future with `REQUIRES: clang`) will be marked as UNSUPPORTED.

In D96510 <https://reviews.llvm.org/D96510> (the third patch), I add LLD to the list of tools these tests look for, if it is in LLVM_ENABLE_PROJECTS, so that tests can be added that use `REQUIRES: lld`. This is subtly different to how the other tools work (the executable won't be searched for in the build paths if it is not in the LLVM_ENABLE_PROJECTS), but probably should be discussed in D96510 <https://reviews.llvm.org/D96510>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95339/new/

https://reviews.llvm.org/D95339