[PATCH] D98684: [LangRef] state that align assume op bundle may take an extra argument

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I like the additions. Some suggestions inlinined. TBH, the fact that we now have "multiple kinds of arguments" is confusing. 
If you agree, maybe we should speak of "operand bundle tag and modifiers" or "operand bundle elements" throughout.



================
Comment at: llvm/docs/LangRef.rst:2252
+  If there are no arguments the attribute is a property of the call location.
+* The following argument(s) if present is argument(s) of the attribute.
 
----------------



================
Comment at: llvm/docs/LangRef.rst:2268-2269
+
+:ref:`llvm.assume <int_assume>`'s condition still has an effect even if
+operand bundles exist. For example,
 
----------------



================
Comment at: llvm/docs/LangRef.rst:2279
 
-Just like for the argument of :ref:`llvm.assume <int_assume>`, if any of the
-provided guarantees are violated at runtime the behavior is undefined.
+``"align"`` optionally takes a second argument.
+``"align"(i8* ptr, i64 a, i64 ofs)`` is equivalent to GCC's
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98684/new/

https://reviews.llvm.org/D98684