[PATCH] D98683: [RISCV] Improve i32 UADDSAT/USUBSAT on RV64.

Tue Mar 16 07:06:34 PDT 2021

luismarques added inline comments.

================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:3529
+    assert(N->getValueType(0) == MVT::i32 && Subtarget.is64Bit() &&
+           "Unexpected custom legalisation");
+    SDLoc DL(N);
----------------
craig.topper wrote:
> luismarques wrote:
> > Nit: British spelling :)
> Yeah I copied and pasted it from one of the other cases. Figured it was best to be consistent.
> Yeah I copied and pasted it from one of the other cases. Figured it was best to be consistent.

Oh, right. I see it's all @asb's original fault :)
Good call. Keep it consistent, and no point in polluting the git blame history changing the others trivially.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98683/new/

https://reviews.llvm.org/D98683