[PATCH] D97484: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 16 06:25:52 PDT 2021


hans updated this revision to Diff 330963.
hans added a comment.

Sorry for the delay, I got distracted by other fires.

I've updated the patch to just use a period as separator in getUniqueModuleId() and tweak any other place I found that used $ as separator on their own.

Please take another look.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97484/new/

https://reviews.llvm.org/D97484

Files:
  llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
  llvm/lib/Transforms/Utils/ModuleUtils.cpp
  llvm/test/Instrumentation/AddressSanitizer/global_with_comdat.ll
  llvm/test/ThinLTO/X86/devirt.ll
  llvm/test/ThinLTO/X86/devirt2.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal-typeid.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal1.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal2.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc-internal.ll
  llvm/test/Transforms/WholeProgramDevirt/export-single-impl.ll
  llvm/tools/llvm-lto2/llvm-lto2.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97484.330963.patch
Type: text/x-patch
Size: 11705 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210316/6eee910d/attachment.bin>


More information about the llvm-commits mailing list