[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

[Abhina Sree via Phabricator via llvm-commits]

abhina.sreeskantharajan marked an inline comment as done.
abhina.sreeskantharajan added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInstance.cpp:771
+        TempPath, fd, TempPath,
+        llvm::sys::fs::all_read | llvm::sys::fs::all_write,
+        Binary ? llvm::sys::fs::OF_None : llvm::sys::fs::OF_Text);
----------------
zibi wrote:
> The ` llvm::sys::fs::all_read | llvm::sys::fs::all_write` seems to be a default so if we make that parameter last we won't need to pass it and worry about the mode parameter which would be the second last default parameter.  Switch parameters only when you determine that indeed `tag` is more frequent parameter which need to be set comparing to `mode` parameter.
Thanks, I've reordered the args as you suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97785/new/

https://reviews.llvm.org/D97785