[PATCH] D98695: [Docs] Suggest mentioning review page in the commit message
Vaivaswatha Nagaraj via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 16 04:21:23 PDT 2021
vaivaswatha created this revision.
vaivaswatha added a reviewer: lattner.
vaivaswatha requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Most commits have a link to the corresponding reviews.llvm.org message. This isn't however mentioned in the developer policy.
https://reviews.llvm.org/D98695
Files:
llvm/docs/DeveloperPolicy.rst
Index: llvm/docs/DeveloperPolicy.rst
===================================================================
--- llvm/docs/DeveloperPolicy.rst
+++ llvm/docs/DeveloperPolicy.rst
@@ -291,6 +291,8 @@
related commit. This could be as simple as "Revert commit NNNN because it
caused PR#".
+* If the patch has been reviewed, add a link to its reviews.llvm.org page.
+
For minor violations of these recommendations, the community normally favors
reminding the contributor of this policy over reverting. Minor corrections and
omissions can be handled by sending a reply to the commits mailing list.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98695.330932.patch
Type: text/x-patch
Size: 598 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210316/5f1b1ef7/attachment.bin>
More information about the llvm-commits
mailing list