[PATCH] D98033: [AArch64][SVEIntrinsicOpts] Factor out redundant SVE mul/fmul intrinsics

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm accepted this revision.
peterwaller-arm added a comment.
This revision is now accepted and ready to land.

LGTM modulo nit.



================
Comment at: llvm/lib/Target/AArch64/SVEIntrinsicOpts.cpp:404
+  // The OpMultiplicand variable should always point to the dup (if any), so
+  // swap if necessary.
+  if (IsUnitDup(OpMultiplier) || IsUnitDupX(OpMultiplier))
----------------
Nit: AFAIUI, typically during canonicalization, constant-like things would appear in the righthand side (multiplier, in this case).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98033/new/

https://reviews.llvm.org/D98033