[PATCH] D98690: [AArch64][SVE] Test more types in sve-fixed-length-subvector.ll

Peter Waller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 16 03:20:42 PDT 2021


peterwaller-arm added a comment.

I think this needs a closer look at the CHECK labels - I see 'CHECK_GE' used where I think 'VBITS_GE' is intended. Also, 'CHECKT', which I take it is not intended.

I'm also not sure about introducing a test beyond the fundamental limitation of 2048 bits. I think it should be dropped for now, at a minimum it would be inconsistent with other files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98690/new/

https://reviews.llvm.org/D98690



More information about the llvm-commits mailing list