[PATCH] D98687: Fix demangling of optional template-args for vendor extended type qualifier.

[James Henderson via Phabricator via llvm-commits]

jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.

I don't know how demangler changes are usually tested, as I don't maintain the lower-level library, but I don't think testing it inside llvm/test/tools/llvm-cxxfilt/ is the right place, as those are tests for the top-level tool features (i.e. changes in the llvm/tools/llvm-cxxfilt/llvm-cxxfilt.cpp). A quick look at past commits to the demangler library and existing tests suggests that you should probably test this in llvm/unittests/Demangle somewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98687/new/

https://reviews.llvm.org/D98687