[PATCH] D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF

[James Henderson via Phabricator via llvm-commits]

jhenderson added a subscriber: Higuoxing.
jhenderson added a comment.

@Higuoxing added more support to yaml2obj last year for DWARF emission via YAML. Maybe it would be best to wait on basic XCOFF yaml2obj support to be finished, add DWARF emission support to that, and then use yaml2obj to generate the DWARF output as required?

Also, the pre-merge checks claim your tests are failing.

Finally, how does this actually add support for llvm-dwarfdump + XCOFF? It's not particularly obvious to me, but I'm not all that familiar about what llvm-dwarfdump requires for this support.



================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:461-472
+  return StringSwitch<StringRef>(Name)
+      .Case("dwinfo", "debug_info")
+      .Case("dwline", "debug_line")
+      .Case("dwpbnms", "debug_pubnames")
+      .Case("dwpbtyp", "debug_pubtypes")
+      .Case("dwarnge", "debug_aranges")
+      .Case("dwabrev", "debug_abbrev")
----------------
This list is missing DWARFv5 section names. Does XCOFF not support those sections?


================
Comment at: llvm/test/tools/llvm-dwarfdump/XCOFF/lit.local.cfg:1-2
+if not 'PowerPC' in config.root.targets:
+    config.unsupported = True
----------------
Why do you need this? As far as I can tell, the behaviour under test is target agnostic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97186/new/

https://reviews.llvm.org/D97186