[PATCH] D98627: [JumpThreading] Do not use AA after a block has been destroyed. PR43276

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 16 00:12:11 PDT 2021


lebedev.ri added a comment.

Would be nice to fix this for real, but not having a not-so-fun-to-debug bug is good-enough.
SGTM, thanks.



================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:456
         Changed = true;
+        // The alias analysis may use LoopInfo inside of it. When we remove
+        // a block, even if it's done lazily, the loop info may still consider
----------------
Please add the same TLDR to the other `AA = nullptr;`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98627/new/

https://reviews.llvm.org/D98627



More information about the llvm-commits mailing list