[llvm] 683e897 - Revert "[cmake] Enable -Werror=return-type"

[David Blaikie via llvm-commits]

Thanks a bunch!

On Mon, Mar 15, 2021 at 10:36 PM Dave <davelee.com at gmail.com> wrote:

> I had commented on the original diff for some of those same reasons:
> https://reviews.llvm.org/D98224#2618043
>
> In future I'll include the same info in the revert too.
>
> Dave
>
> On Monday, March 15, 2021, David Blaikie <dblaikie at gmail.com> wrote:
>
>> please include some details about why a patch is being reverted in the
>> commit description - it helps folks understand if a patch would be relevant
>> to some issue they're investigating, or avoid making the same mistake in a
>> later/similar change, etc
>>
>>
>> On Wed, Mar 10, 2021 at 2:47 PM Dave Lee via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>>
>>> Author: Dave Lee
>>> Date: 2021-03-10T14:47:08-08:00
>>> New Revision: 683e89722aa0fd9afd41fb0799e46e1b28db1de6
>>>
>>> URL:
>>> https://github.com/llvm/llvm-project/commit/683e89722aa0fd9afd41fb0799e46e1b28db1de6
>>> DIFF:
>>> https://github.com/llvm/llvm-project/commit/683e89722aa0fd9afd41fb0799e46e1b28db1de6.diff
>>>
>>> LOG: Revert "[cmake] Enable -Werror=return-type"
>>>
>>> This reverts commit ce94a161651d0edd313d0fa65571eb53d3a34d13.
>>>
>>> Added:
>>>
>>>
>>> Modified:
>>>     llvm/cmake/modules/HandleLLVMOptions.cmake
>>>
>>> Removed:
>>>
>>>
>>>
>>>
>>> ################################################################################
>>> diff  --git a/llvm/cmake/modules/HandleLLVMOptions.cmake
>>> b/llvm/cmake/modules/HandleLLVMOptions.cmake
>>> index 911275f21124..32fb4e10e31e 100644
>>> --- a/llvm/cmake/modules/HandleLLVMOptions.cmake
>>> +++ b/llvm/cmake/modules/HandleLLVMOptions.cmake
>>> @@ -745,10 +745,6 @@ if (LLVM_ENABLE_WARNINGS AND
>>> (LLVM_COMPILER_IS_GCC_COMPATIBLE OR CLANG_CL))
>>>
>>>    # Enable -Wstring-conversion to catch misuse of string literals.
>>>    add_flag_if_supported("-Wstring-conversion" STRING_CONVERSION_FLAG)
>>> -
>>> -  # Enable -Werror=return-type if available, to catch functions that
>>> contain
>>> -  # control paths that do not return a value.
>>> -  add_flag_if_supported("-Werror=return-type" WERROR_RETURN_TYPE)
>>>  endif (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_COMPATIBLE OR
>>> CLANG_CL))
>>>
>>>  if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND NOT LLVM_ENABLE_WARNINGS)
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210315/b1e6ed71/attachment-0001.html>