[PATCH] D98560: [RuntimeDyld] Fix range checks for R_X86_64_{8,16}

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 15 20:20:11 PDT 2021


lhames requested changes to this revision.
lhames added a comment.
This revision now requires changes to proceed.

> Changing that would be more involved (as the entire lib has to change -- all code dealing with relocs from all targets).

There is actually an existing error reporting mechanism, it's just *very* poorly used / documented. You can set `HasError = true` and `ErrorStr = <msg>`. That's the right way to check this.

What platforms is BOLT running on? You might be able to switch to JITLink either now or in the near future -- error handling is in a much better state there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98560/new/

https://reviews.llvm.org/D98560



More information about the llvm-commits mailing list