[PATCH] D98650: [NVPTX] Enable lowering of atomics on local memory

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

No test.



================
Comment at: llvm/lib/Target/NVPTX/NVPTXAtomicLower.cpp:70
+  return Changed;
+}
+
----------------
`V` is not a descriptive name.
`auto*` where appropriate.
if the type is not clean, don't use auto.
Why only for monotonic orderings?
Why only FAdd?
Don't we have an existing way to "deconstruct" atomics intriniscs into loads/stores?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98650/new/

https://reviews.llvm.org/D98650