[PATCH] D98620: [NFC] Update PowerPC readobj test case with expression for Index and ContainingCsectSymbolIndex

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

Please indicate this is for XCOFF in the title and a follow-up of the patch D97117 <https://reviews.llvm.org/D97117> in the description.



================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-data.ll:213
 ; SYMS-NEXT:   Symbol {
-; SYMS-NEXT:     Index: 0
+; SYMS-NEXT:     Index: [[#INDX:]]
 ; SYMS-NEXT:     Name: .file
----------------
This seems not right as for now symbol 0 is always for `.file`, we don't need to make this one as the base, otherwise there is no meaning at all for this change.  Now with this change, when we add some aux entry for `.file` symbol, we need to update all the following symbol entries. Without the change, with the `.text` symbol base, we don't need to do any change to existing symbols.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-reloc.ll:151
 ; SYM-NEXT:   Symbol {
-; SYM-NEXT:     Index: 0
+; SYM-NEXT:     Index: [[#INDX:]]
 ; SYM-NEXT:     Name: .file
----------------
Same as above, use symbol for `.bar` as the base


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/symbols.test:37
 SYMBOL32-NEXT:   Symbol {
-SYMBOL32-NEXT:     Index: 0
+SYMBOL32-NEXT:     Index: [[#INDX:]]
 SYMBOL32-NEXT:     Name: .file
----------------
We don't need to change this file as the object file is created by XLC and it will not be changed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98620/new/

https://reviews.llvm.org/D98620