[PATCH] D97074: Add getDemandedBits for uses.

Qunyan Mangus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 15 17:24:26 PDT 2021


qunyanm added a comment.

In D97074#2579069 <https://reviews.llvm.org/D97074#2579069>, @lebedev.ri wrote:

> The patch's description states what the patch does, but not *why* it does that.

I reworded the commit message. Just realized that I'm not sure if that's the patch's description you were referring to. Please let me know if it's wrong and how to update it. Sorry, I should've asked first.



================
Comment at: llvm/lib/Analysis/DemandedBits.cpp:465
+
+  unsigned BitWidth = T->getScalarSizeInBits();
+
----------------
RKSimon wrote:
> Could this be used in the APInt::getAllOnesValue() above instead of the getTypeSizeInBits call?
Yes. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97074/new/

https://reviews.llvm.org/D97074



More information about the llvm-commits mailing list