[PATCH] D98666: [AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax"

Anirudh Prasad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 15 16:12:05 PDT 2021


anirudhp created this revision.
Herald added subscribers: hiraditya, mgorny.
anirudhp requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

- Previously, https://reviews.llvm.org/D97703 was reverted <https://reviews.llvm.org/D98543> as it broke when building the unit tests when shared libs on.
- This patch reverts the "revert" and makes two minor changes
- The first is it also links in the MCParser lib when building the unittest. This should resolve the issue when building with with shared libs on and off
- The second renames the name of the unit test from `SystemZAsmLexer` to `SystemZAsmLexerTests` since the convention for unittest binaries is to suffix the name of the unit test with "Tests"


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98666

Files:
  llvm/include/llvm/MC/MCAsmInfo.h
  llvm/lib/MC/MCParser/AsmLexer.cpp
  llvm/lib/Target/SystemZ/MCTargetDesc/SystemZMCAsmInfo.cpp
  llvm/unittests/MC/SystemZ/CMakeLists.txt
  llvm/unittests/MC/SystemZ/SystemZAsmLexerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98666.330833.patch
Type: text/x-patch
Size: 8307 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210315/e29485f4/attachment.bin>


More information about the llvm-commits mailing list