[PATCH] D98603: [Flang] [OpenMP] Add function for mapping OpenMP Parser clause classes with the corresponding clause kind

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.

Thanks for this patch. Couple of nits.



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:843-845
+  //   TODO: Verify the assumption here that the immediately enclosing region is
+  //   the parallel region to which the worksharing construct having reduction
+  //   binds to.
----------------
Nit: extra space?


================
Comment at: llvm/utils/TableGen/DirectiveEmitter.cpp:652
+// corresponding clause Kind
+void GenerateFlangClauseParserKindMap(const DirectiveLanguage &DirLang,
+                                      raw_ostream &OS) {
----------------
Would it be possible to add a test in the following file?
test/TableGen/directive1.td


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98603/new/

https://reviews.llvm.org/D98603