[PATCH] D98532: [M68k] Use fixed asm string for MxPseudo instructions

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 15 14:47:10 PDT 2021


myhsu added a comment.

In D98532#2626683 <https://reviews.llvm.org/D98532#2626683>, @RKSimon wrote:

> @myhsu Would we be better off adding non-empty asm strings to all uses?

Do you mean setting non-empty asm string by default on `MxInst`? I feel like the non-empty string requirement imposed by parser table can help us catch mistakes if we forget to set assembly string for an instruction (in the future), so I'm incline not to do that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98532/new/

https://reviews.llvm.org/D98532



More information about the llvm-commits mailing list