[PATCH] D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 15 14:16:09 PDT 2021
jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.
I think what we usually do for test case is to upstream some pre-compiled binaries for testing purpose. But that's not the way community preferred anyway because those binaries are baked, and might be hard to reproduce later. Given this patch is small and pretty self-explanatory, I'm okay with skipping the test and let D97184 <https://reviews.llvm.org/D97184> to "test" it.
FYI @hubert.reinterpretcast in case he think we should still upstream a pre-compiled binary for testing.
Otherwise, the patch LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97186/new/
https://reviews.llvm.org/D97186
More information about the llvm-commits
mailing list