[PATCH] D92504: [ms] [llvm-ml] When warnings are fatal, make sure to fail on warnings
Eric Astor via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 15 14:15:06 PDT 2021
epastor updated this revision to Diff 330808.
epastor added a comment.
Rebase on parent
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92504/new/
https://reviews.llvm.org/D92504
Files:
llvm/lib/MC/MCParser/MasmParser.cpp
Index: llvm/lib/MC/MCParser/MasmParser.cpp
===================================================================
--- llvm/lib/MC/MCParser/MasmParser.cpp
+++ llvm/lib/MC/MCParser/MasmParser.cpp
@@ -4472,8 +4472,9 @@
return addErrorSuffix(" in align directive");
// Ignore empty 'align' directives.
if (getTok().is(AsmToken::EndOfStatement)) {
- Warning(AlignmentLoc, "align directive with no operand is ignored");
- return parseToken(AsmToken::EndOfStatement);
+ return Warning(AlignmentLoc,
+ "align directive with no operand is ignored") &&
+ parseToken(AsmToken::EndOfStatement);
}
if (parseAbsoluteExpression(Alignment) ||
parseToken(AsmToken::EndOfStatement))
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92504.330808.patch
Type: text/x-patch
Size: 723 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210315/3798da38/attachment.bin>
More information about the llvm-commits
mailing list