[PATCH] D98629: [RISCV] Spilling for Zvlsseg registers.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 15 14:14:29 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:226
+      // will be used when expanding these pseudo instructions.
+      MIB.addReg(RISCV::X0).addImm(0).addImm(0);
+    }
----------------
Why do we need these fields as immediates if they are already part of the opcode name? Can't we just use the switch in isRVVSpillForZvlsseg to look them up anytime we need them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98629/new/

https://reviews.llvm.org/D98629



More information about the llvm-commits mailing list