[PATCH] D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records

[Yusra Syeda via Phabricator via llvm-commits]

yusra.syeda added inline comments.


================
Comment at: llvm/include/llvm/Object/GOFF.h:405
+
+class ContinuationRecord : public Record {
+public:
----------------
kpn wrote:
> Why make ContinuationRecord appear to be a type of record like ESD, HDR, and END are types of record? I'd have a layer that deals with cards and presents to the layer above it all payload data from initial and continued records combined. Then the code handling the various types of record wouldn't have to know about continuation records.
Thanks for the suggestion, I will work on updating how continuation records are handled. 


================
Comment at: llvm/include/llvm/Object/GOFFObjectFile.h:112
+  // RelocationRef.
+  void moveRelocationNext(DataRefImpl &Rel) const override {};
+  uint64_t getRelocationOffset(DataRefImpl Rel) const override { return 0; }
----------------
kpn wrote:
> Isn't this for RLD cards and thus should be in the commit that adds support for them?
These are required due to the pure virtual interfaces, but I stubbed out the logic for this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98437/new/

https://reviews.llvm.org/D98437