[PATCH] D98226: [CSSPGO][llvm-profgen] Fix getCanonicalFnName usage in llvm-profgen

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/test/tools/llvm-profgen/fname-canonicalization.test:1
+; Test unique linkage name decoding and canonicalization from dwarf debug info
+; RUN: llvm-profgen --perfscript=%S/Inputs/unique-linkage-name-dwarf.perfscript --binary=%S/Inputs/unique-linkage-name-dwarf.perfbin --output=%t --csprof-cold-thres=0
----------------
wmi wrote:
> Since the default strategy of getCanonicalFnName is "selected" which is trying to keep ".__uniq." suffix if it exists, so I guess the test will behave the same no matter whether getCanonicalFnName is functioning or not, is that correct? If that is the case, maybe add another type of "suffix" like '.llvm.' in the test?
Yes. Good point to add a test for other suffix.

Added the '.llvm.1000' suffix to the symbolizer test(provide a switch ` --show-canonical-fname` for this). With the  --show-canonical-fname, it will get rid of the '.llvm.1000' suffix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98226/new/

https://reviews.llvm.org/D98226