[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

[Markus Böck via Phabricator via llvm-commits]

zero9178 added a comment.

In D98278#2626868 <https://reviews.llvm.org/D98278#2626868>, @abhina.sreeskantharajan wrote:

> These changes look good. One more thought I had is that instead of defaulting to python's os.strerror we can emit an error or warning saying that the errc_message is not defined for the project. What do you think?

I like that idea a lot actually! One problem I see however, is that it would probably create noise in every project, even those not using errc substitutions. An initial implementation of mine warned inside of `add_err_msg_substitution`, which is called in basically every project. Ideally it'd warn on the first usage of an errc substitution but that seems rather non-trivial and/or ugly to implement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98278/new/

https://reviews.llvm.org/D98278