[PATCH] D98558: [OPENMP51]Initial support for the interop directive

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 15 11:38:15 PDT 2021


ABataev added inline comments.


================
Comment at: clang/include/clang/AST/OpenMPClause.h:7491
+/// \endcode
+class OMPUseClause final : public OMPClause {
+  friend class OMPClauseReader;
----------------
mikerice wrote:
> ABataev wrote:
> > mikerice wrote:
> > > ABataev wrote:
> > > > I suggest splitting this patch anŠ² keep just one clause. Other clauses should be added in follow-up patches.
> > > Sorry I should have done that.  Unfortunately the logic is somewhat shared among these three and breaking it up at this point would mean rewriting it without those interactions.  I can do it if you really want me to.
> > Better to split, if possible.
> Should be possible.  Is it better to start a new review or just update this one?
Just update this one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98558/new/

https://reviews.llvm.org/D98558



More information about the llvm-commits mailing list