[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 15 11:34:25 PDT 2021


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:53
 
+void RISCVInstrInfo::getNoop(MCInst &NopInst) const {
+  if (STI.getFeatureBits()[RISCV::FeatureStdExtC])
----------------
jrtc27 wrote:
> I will forever wonder why TII didn't make it `MCInst getNoop()`...
Let me do a refactoring before this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98610/new/

https://reviews.llvm.org/D98610



More information about the llvm-commits mailing list