[PATCH] D98422: [Alias] Add a ah-hoc pattern with two PHI for isKnownNonEqual

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 15 10:34:36 PDT 2021


lebedev.ri added a comment.

In D98422#2626105 <https://reviews.llvm.org/D98422#2626105>, @jaykang10 wrote:

> Following @lebedev.ri comments, moved the change to a new helper function and updated redundant code.

Did you upload the right diff? I think not all inline comments were addressed.



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2566
+
+      IsNonEqual = false;
+      break;
----------------
Now that it is in a separate function, early return can be used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98422/new/

https://reviews.llvm.org/D98422



More information about the llvm-commits mailing list