[PATCH] D90831: DebugInfo support for OCaml bindings

Vaivaswatha Nagaraj via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 15 08:31:55 PDT 2021


vaivaswatha added inline comments.


================
Comment at: llvm/bindings/ocaml/debuginfo/debuginfo_ocaml.c:168
+  LLVMDIFlags Flags = 0;
+  Flags |= map_DIFlag(Int_val(i_Flag));
+  return alloc_diflags(Flags);
----------------
jberdine wrote:
> why `|`?
This is strange. I can't recall why I used `|=`. It's likely that it was an overlook / typo. I've fixed this now. Thank you for catching this !


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90831/new/

https://reviews.llvm.org/D90831



More information about the llvm-commits mailing list