[PATCH] D98256: [flang] Save AllocateObject and PointerObject analyzed expression
    Jean Perier via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Mar 15 08:02:50 PDT 2021
    
    
  
jeanPerier marked an inline comment as done.
jeanPerier added inline comments.
================
Comment at: flang/lib/Semantics/check-deallocate.cpp:49
               }
+              return {};
             },
----------------
tskeith wrote:
> This case could be simplified slightly:
> ```
>   MaybeExpr checked{analyzer.Analyze(structureComponent)};
>   if (checked && ...
>   }
>   return checked;
> ```
> This reduces the indentation and make the explicit return type unnecessary.
This comment is not really applicable anymore after the patch update.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98256/new/
https://reviews.llvm.org/D98256
    
    
More information about the llvm-commits
mailing list