[PATCH] D83372: Fix for memory leak reported by Valgrind

Maksym Wezdecki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 15 06:54:00 PDT 2021


mwezdeck added a comment.

In D83372#2581740 <https://reviews.llvm.org/D83372#2581740>, @amaiorano wrote:

> @mwezdeck Do you think you can update this patch with the recommendations above, namely:
>
> - Add a comment to llvm_shutdown to say it's only safe to call without any other threads executing LLVM APIs.
> - Remove the locking of getManagedStaticMutex() in llvm_shutdown altogether.
>
> It would be great to land this patch with these changes.

I have uploaded new version of the patch. Please, review it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83372/new/

https://reviews.llvm.org/D83372



More information about the llvm-commits mailing list