[PATCH] D98495: [CodeGen] Fix issues with scalable-vector INSERT/EXTRACT_SUBVECTORs

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck marked an inline comment as done.
frasercrmck added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1293
+  if (VecVT.isScalableVector() == SubVecVT.isScalableVector()) {
+    if (IdxVal >= LoElems && IdxVal + SubElems <= VecElems) {
+      Hi = DAG.getNode(ISD::INSERT_SUBVECTOR, dl, Hi.getValueType(), Hi, SubVec,
----------------
craig.topper wrote:
> Merge these with an && to decrease indentation?
Yep, makes sense. Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98495/new/

https://reviews.llvm.org/D98495