[PATCH] D97954: [RISCV] Support fixed-length vectors in the calling convention

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 15 03:51:19 PDT 2021


frasercrmck marked an inline comment as done.
frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:5138
     MVT ArgVT = ArgIdx.value().VT;
-    if (ArgVT.isScalableVector() &&
-        ArgVT.getVectorElementType().SimpleTy == MVT::i1)
+    if (ArgVT.isVector() && ArgVT.getVectorElementType().SimpleTy == MVT::i1)
       return ArgIdx.index();
----------------
craig.topper wrote:
> i know it was there before, but the ".SimpleTy" here is redundant.
Thanks. I fixed that up prior to pushing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97954/new/

https://reviews.llvm.org/D97954



More information about the llvm-commits mailing list