[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

Mon Mar 15 03:23:01 PDT 2021

DmitryPolukhin added a comment.

In D97563#2624680 <https://reviews.llvm.org/D97563#2624680>, @njames93 wrote:

> Is DAG required because the header file warnings are printed in a different order depending on things like platform?

@njames93 Thank you for review! Yes, on Windows build bot showed different order of the messages so I added `-DAG` to don't depend on any particular order.

In D97563#2625513 <https://reviews.llvm.org/D97563#2625513>, @lebedev.ri wrote:

> I think the implicit question is: won't this regress headers that are meant to be compatible with earlier standards?
> Did the original review mention anything about this?

In the original code review it was not discussed. Moreover it is more or less applicable to all modernize-* checks and they work in headers selected with `--header-filter` so I think these is no reason to invent special mechanism only for this check.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97563/new/

https://reviews.llvm.org/D97563