[PATCH] D98124: [RISCV] Clean up parsing fence arguments

[Luís Marques via Phabricator via llvm-commits]

luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1706-1717
+    case 'i':
+      Imm |= RISCVFenceField::I;
+      break;
+    case 'o':
+      Imm |= RISCVFenceField::O;
+      break;
+    case 'r':
----------------
Keep the original in-line formatting?


================
Comment at: llvm/test/MC/RISCV/rv32i-invalid.s:5-7
+fence iorw, iore # CHECK: :[[@LINE]]:13: error: letters must be selected from 'iorw'
+fence wr, wr # CHECK: :[[@LINE]]:7: error: letters must be in the order 'iorw'
+fence rw, rr # CHECK: :[[@LINE]]:11: error: letters must not be duplicated
----------------
letters -> operand letters?


================
Comment at: llvm/test/MC/RISCV/rv32i-invalid.s:9
 fence 1, rw # CHECK: :[[@LINE]]:7: error: operand must be formed of letters selected in-order from 'iorw'
-fence unknown, unknown # CHECK: :[[@LINE]]:7: error: operand must be formed of letters selected in-order from 'iorw'
+fence unknown, unknown # CHECK: :[[@LINE]]:7: error: letters must be selected from 'iorw'
 
----------------
ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98124/new/

https://reviews.llvm.org/D98124