[PATCH] D98401: [CodeGen] Fix backward copy propagation with -g

[Zhiwei Chen via Phabricator via llvm-commits]

condy added inline comments.


================
Comment at: llvm/test/CodeGen/X86/machine-cp-clobbers.mir:10-11
+    ; CHECK: renamable $rbx = LEA64r $rax, 1, $noreg, 8, $noreg
+    ; CHECK: DBG_VALUE $rbp, $noreg
+    ; CHECK: DBG_VALUE $noreg, $noreg
+    renamable $rbx = LEA64r $rax, 1, $noreg, 8, $noreg
----------------
Orlando wrote:
> Just to check I understand, `renamable $rbx = COPY killed renamable $rbp` should be removed by this pass (with your patch applied) because it's a redundant copy, right?
> 
> I think these should be `CHECK-NEXT` directives (see https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-next-directive). Otherwise the test will pass even if `renamable $rbx = COPY killed renamable $rbp` is not removed.
Yes, the last two `CHECK`s should be `CHECK-NEXT`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98401/new/

https://reviews.llvm.org/D98401