[PATCH] D98569: [llvm-nm] Add --format=just-symbols and make --just-symbol-name its alias
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 15 01:18:30 PDT 2021
jhenderson added inline comments.
================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:777-781
if (OutputFormat == posix && MultipleFiles && printName) {
outs() << '\n' << CurrentFilename << ":\n";
} else if (OutputFormat == bsd && MultipleFiles && printName) {
outs() << "\n" << CurrentFilename << ":\n";
} else if (OutputFormat == sysv) {
----------------
By making -j an output format, the code here could change in behaviour, if I understand it correctly, so the `--print-file-name` option will not be respected anymore. It //probably// doesn't matter too much, but perhaps we should treat -j as the same output format as bsd/posix here (speaking of which, feel free to fold the two semantically identical cases together here whilst you're at it).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98569/new/
https://reviews.llvm.org/D98569
More information about the llvm-commits
mailing list