[PATCH] D98362: [AMDGPU] Fix -amdgpu-inline-arg-alloca-cost

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec updated this revision to Diff 330270.
rampitec marked 2 inline comments as done.
rampitec added a comment.
Herald added subscribers: haicheng, eraman.

Swapped order of operations in the InlineCost itself instead. This is still unused by any other target so it is possible to fix it there, which seems to be a more correct way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98362/new/

https://reviews.llvm.org/D98362

Files:
  llvm/lib/Analysis/InlineCost.cpp


Index: llvm/lib/Analysis/InlineCost.cpp
===================================================================
--- llvm/lib/Analysis/InlineCost.cpp
+++ llvm/lib/Analysis/InlineCost.cpp
@@ -1577,10 +1577,11 @@
     }
   }
 
+  Threshold += TTI.adjustInliningThreshold(&Call);
+
   // Finally, take the target-specific inlining threshold multiplier into
   // account.
   Threshold *= TTI.getInliningThresholdMultiplier();
-  Threshold += TTI.adjustInliningThreshold(&Call);
 
   SingleBBBonus = Threshold * SingleBBBonusPercent / 100;
   VectorBonus = Threshold * VectorBonusPercent / 100;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98362.330270.patch
Type: text/x-patch
Size: 586 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210312/cb45e599/attachment.bin>