[PATCH] D98553: [flang] Runtime: implement INDEX intrinsic function

[Asher Mancinelli via Phabricator via llvm-commits]

ashermancinelli added a comment.

LGTM



================
Comment at: flang/unittests/RuntimeGTest/CharacterTest.cpp:191-195
+      {"Fortran that you ran", "that I ran", false, 0},
+      {"Fortran that you ran", "that I ran", true, 0},
+  };
+  RunSearchTests(
+      "INDEX", tests, std::get<SearchFunction<TypeParam>>(functions));
----------------
This approach is far more concise and readable IMO. I'm impressed it's generic enough to work for all three SUT functions for all char types!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98553/new/

https://reviews.llvm.org/D98553