[PATCH] D98595: [NFC] Refactor the code to avoid check target type.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 14 04:45:19 PDT 2021


lebedev.ri resigned from this revision.
lebedev.ri added a comment.

IMHO being explicit about the ugliness of the hack (LHS of the diff) is better than inventing a confusing misnomer (how is bitcast between pointers with same address space not lossless?) and hiding behind it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98595/new/

https://reviews.llvm.org/D98595



More information about the llvm-commits mailing list