[PATCH] D90831: DebugInfo support for OCaml bindings

[Vaivaswatha Nagaraj via Phabricator via llvm-commits]

vaivaswatha updated this revision to Diff 330500.
vaivaswatha added a comment.

The updated patch incorporates all (but one - see below) review comments by @jberdine.

> improve the usability of these APIs to introduce some types to mirror the C++ type hierarchy. For instance, defining:
> type llsubprogram = private llscope

This won't work because a scope can be either a subprogram or a lexical block. We would need something like `type llscope = | Subprogram of llmetadata | LexicalBlock of llmetadata`.

However my attempt at implementing this whole comment didn't quite succeed. For example, A file can be a scope too in the argument to `dibuild_create_function`, but `dibuild_create_debug_location` cannot have a file scope.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90831/new/

https://reviews.llvm.org/D90831

Files:
  llvm/bindings/ocaml/.ocamlformat
  llvm/bindings/ocaml/CMakeLists.txt
  llvm/bindings/ocaml/README.txt
  llvm/bindings/ocaml/debuginfo/CMakeLists.txt
  llvm/bindings/ocaml/debuginfo/debuginfo_ocaml.c
  llvm/bindings/ocaml/debuginfo/llvm_debuginfo.ml
  llvm/bindings/ocaml/debuginfo/llvm_debuginfo.mli
  llvm/bindings/ocaml/llvm/META.llvm.in
  llvm/bindings/ocaml/llvm/llvm.ml
  llvm/bindings/ocaml/llvm/llvm.mli
  llvm/bindings/ocaml/llvm/llvm_ocaml.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90831.330500.patch
Type: text/x-patch
Size: 72332 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210314/0624c69f/attachment-0001.bin>