[PATCH] D98593: [OCaml][test] Fix Bindings/OCaml/executionengine.ml test

Josh Berdine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 13 16:29:36 PST 2021


jberdine created this revision.
jberdine added reviewers: whitequark, vaivaswatha, liuz.
jberdine requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

It seems that at some point it became necessary to pass `-thread` to
the ocaml compiler for this test. Before this diff running
`llvm-lit -v llvm/test/bindings/ocaml` included

  File "test/bindings/ocaml/Output/executionengine.ml.tmp/executionengine.ml", line 1:
  Error: Module `Mutex' is unavailable (required by `Foreign')

and with this diff it passes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98593

Files:
  llvm/test/Bindings/OCaml/executionengine.ml


Index: llvm/test/Bindings/OCaml/executionengine.ml
===================================================================
--- llvm/test/Bindings/OCaml/executionengine.ml
+++ llvm/test/Bindings/OCaml/executionengine.ml
@@ -1,7 +1,7 @@
 (* RUN: rm -rf %t && mkdir -p %t && cp %s %t/executionengine.ml
- * RUN: %ocamlc -g -w +A -package llvm.executionengine -linkpkg %t/executionengine.ml -o %t/executable
+ * RUN: %ocamlc -g -w +A -thread -package llvm.executionengine -linkpkg %t/executionengine.ml -o %t/executable
  * RUN: %t/executable
- * RUN: %ocamlopt -g -w +A -package llvm.executionengine -linkpkg %t/executionengine.ml -o %t/executable
+ * RUN: %ocamlopt -g -w +A -thread -package llvm.executionengine -linkpkg %t/executionengine.ml -o %t/executable
  * RUN: %t/executable
  * REQUIRES: native
  * XFAIL: vg_leak


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98593.330483.patch
Type: text/x-patch
Size: 818 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210314/a105591a/attachment.bin>


More information about the llvm-commits mailing list