[PATCH] D98582: [llvm-objcopy] remove split dwo file creation from executeObjcopyOnBinary.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 13 08:37:05 PST 2021


avl created this revision.
avl added reviewers: rupprecht, jhenderson, MaskRay, dblaikie, alexshap.
Herald added subscribers: abrachet, emaste.
avl requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This patch removes creation of the resulting file from the
executeObjcopyOnBinary() function. For the most use cases, the
executeObjcopyOnBinary receives output file as a parameter

- raw_ostream &Out. The splitting .dwo file is implemented differently:

file containg .dwo tables is created inside executeObjcopyOnBinary().
When objcopy functionality would be moved into separate library,
current implementation will become inconvenient. The goal of that
refactoring is to separate concerns: It might be convenient to
to do dwo tables splitting but to create resulting file differently.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98582

Files:
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98582.330454.patch
Type: text/x-patch
Size: 9025 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210313/61e83f65/attachment.bin>


More information about the llvm-commits mailing list