[PATCH] D98580: [flang][OpenMP] Add support for getting parent context and clauses and modify the relevant sema checks to use the new functions.
Kiran Chandramohan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 13 08:31:39 PST 2021
kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.
LGTM. Approving quickly since it fixes failures. Might need to do a recce and check that usage is consistent.
================
Comment at: flang/lib/Semantics/check-directive-structure.h:155
+ CHECK(!dirContext_.empty());
+ CHECK(dirContext_.size() >= 2);
+ return dirContext_[dirContext_.size() - 2];
----------------
Nit: Are both checks necessary, given that the second includes the first?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98580/new/
https://reviews.llvm.org/D98580
More information about the llvm-commits
mailing list