[PATCH] D98571: [lld-macho] Optimize getRelocAttrs()

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 13 07:20:55 PST 2021


int3 added a comment.

I'm aware :) the reason why we're using it here is because we need `upper_bound()`. That said, a sorted vector (as mentioned in the manual) might help here... `parseSymbols` interleaves inserts and queries to the SubsectionMaps, but `parseRelocations` only does queries, so we could convert the map to a vector in the latter case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98571/new/

https://reviews.llvm.org/D98571



More information about the llvm-commits mailing list