[llvm] 23d591e - [NFC][LSR] Add test case that from https://reviews.llvm.org/D98147#2623549

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 13 05:06:02 PST 2021


Author: Roman Lebedev
Date: 2021-03-13T16:05:33+03:00
New Revision: 23d591efae68604a8620cbb1a7755eee0279290e

URL: https://github.com/llvm/llvm-project/commit/23d591efae68604a8620cbb1a7755eee0279290e
DIFF: https://github.com/llvm/llvm-project/commit/23d591efae68604a8620cbb1a7755eee0279290e.diff

LOG: [NFC][LSR] Add test case that from https://reviews.llvm.org/D98147#2623549

With that patch, this test fails with an assertion
```
opt: /repositories/llvm-project/llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:5169: BasicBlock::iterator (anonymous namespace)::LSRInstance::AdjustInsertPositionForExpand(BasicBlock::iterator, const (anonymous namespace)::LSRFixup &, const (anonymous namespace)::LSRUse &, llvm::SCEVExpander &) const: Assertion `!isa<PHINode>(LowestIP) && !LowestIP->isEHPad() && !isa<DbgInfoIntrinsic>(LowestIP) && "Insertion point must be a normal instruction"' failed.
```

Added: 
    llvm/test/Transforms/LoopStrengthReduce/X86/eh-insertion-point.ll

Modified: 
    

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/LoopStrengthReduce/X86/eh-insertion-point.ll b/llvm/test/Transforms/LoopStrengthReduce/X86/eh-insertion-point.ll
new file mode 100644
index 000000000000..1b7748ccaa8a
--- /dev/null
+++ b/llvm/test/Transforms/LoopStrengthReduce/X86/eh-insertion-point.ll
@@ -0,0 +1,44 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -S -loop-reduce < %s | FileCheck %s
+
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+declare void @maybe_throws()
+declare void @use1(i1)
+
+define void @is_not_null(i8* %baseptr) local_unnamed_addr align 2 personality i8* undef {
+; CHECK-LABEL: @is_not_null(
+; CHECK-NEXT:  preheader:
+; CHECK-NEXT:    br label [[HEADER:%.*]]
+; CHECK:       header:
+; CHECK-NEXT:    [[PTR:%.*]] = phi i8* [ [[INCPTR:%.*]], [[LATCH:%.*]] ], [ [[BASEPTR:%.*]], [[PREHEADER:%.*]] ]
+; CHECK-NEXT:    invoke void @maybe_throws()
+; CHECK-NEXT:    to label [[LATCH]] unwind label [[LPAD:%.*]]
+; CHECK:       lpad:
+; CHECK-NEXT:    [[TMP0:%.*]] = landingpad { i8*, i32 }
+; CHECK-NEXT:    catch i8* null
+; CHECK-NEXT:    [[PTR_IS_NOT_NULL:%.*]] = icmp ne i8* [[PTR]], null
+; CHECK-NEXT:    call void @use1(i1 [[PTR_IS_NOT_NULL]])
+; CHECK-NEXT:    ret void
+; CHECK:       latch:
+; CHECK-NEXT:    [[INCPTR]] = getelementptr inbounds i8, i8* [[PTR]], i64 1
+; CHECK-NEXT:    br label [[HEADER]]
+;
+preheader:
+  br label %header
+
+header:
+  %ptr = phi i8* [ %incptr, %latch ], [ %baseptr, %preheader ]
+  invoke void @maybe_throws() to label %latch unwind label %lpad
+
+lpad:
+  landingpad { i8*, i32 } catch i8* null
+  %ptr_is_not_null = icmp ne i8* %ptr, null
+  call void @use1(i1 %ptr_is_not_null)
+  ret void
+
+latch:
+  %incptr = getelementptr inbounds i8, i8* %ptr, i64 1
+  br label %header
+}


        


More information about the llvm-commits mailing list